Skip to content

[universal] & [actions] fix smoke tests: drop unbundled setuptools check and harden tag validation against Docker Hub rate limiting#1902

Closed
V-Subhankar-infy wants to merge 4 commits into
devcontainers:mainfrom
V-Subhankar-infy:fix-universal
Closed

[universal] & [actions] fix smoke tests: drop unbundled setuptools check and harden tag validation against Docker Hub rate limiting#1902
V-Subhankar-infy wants to merge 4 commits into
devcontainers:mainfrom
V-Subhankar-infy:fix-universal

Conversation

@V-Subhankar-infy

@V-Subhankar-infy V-Subhankar-infy commented Jun 22, 2026

Copy link
Copy Markdown
Member

PR Marked close to make sure 2 complex changes are kept in seperate commits in main, Hence 2 fresh PR's were raised instead of this:

  1. 1904 for Fixing Universal
  2. 1905 for Fixing Smoke Tests

@V-Subhankar-infy V-Subhankar-infy changed the title [universal]- fix smoke test (Restore setuptools install for python) [universal]- fix smoke test (remove test for setuptools that's no more default bundled in python) Jun 23, 2026
@V-Subhankar-infy V-Subhankar-infy marked this pull request as ready for review June 23, 2026 07:23
@V-Subhankar-infy V-Subhankar-infy requested a review from a team as a code owner June 23, 2026 07:23
Copilot AI review requested due to automatic review settings June 23, 2026 07:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the universal image smoke test to align with upstream Python behavior (Python 3.12+ no longer bundles setuptools by default), by removing a now-stale assertion that expected setuptools to be present in the standalone Python environment.

Changes:

  • Removed the setuptools version assertion from the standalone Python smoke-test checks.
  • Kept the remaining Python smoke-test assertions (e.g., requests) unchanged.

@V-Subhankar-infy V-Subhankar-infy marked this pull request as draft June 23, 2026 08:33
@V-Subhankar-infy V-Subhankar-infy changed the title [universal]- fix smoke test (remove test for setuptools that's no more default bundled in python) [universal] & [actions] fix smoke tests: drop unbundled setuptools check and harden tag validation against Docker Hub rate limiting Jun 23, 2026

@Kaniska244 Kaniska244 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the tag validation change, review comments provided in duplicate PR: #1903

@V-Subhankar-infy V-Subhankar-infy deleted the fix-universal branch June 24, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants