Repository navigation
fix(gallery): provide previews for every published component - #95
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Yash121l
left a comment
There was a problem hiding this comment.
Looks good. Every published component now gets a preview, and the preview ?? fallback keeps future additions from rendering an empty card.
Note: the date-range-picker preview is sized assuming the current component. If #89 lands as it stands (fixed w-[880px] root), the max-w-full cap still holds inside the 600px wrapper, but it's worth checking this card again after #89 merges.
CI checks pass. The Vercel devclubcompo failure shows up on every PR and on main ("Account is blocked"), so it is not caused by this change.
|
@Heyykrishnna this is approved, but One-time setup (SSH signing): git config --global gpg.format ssh
git config --global user.signingkey ~/.ssh/id_ed25519.pub
git config --global commit.gpgsign trueAdd the same public key on GitHub under Settings → SSH and GPG keys → New SSH key with key type Signing Key. Also make sure the commit email ( Then on this branch: git rebase --exec 'git commit --amend --no-edit -S' origin/main
git push --force-with-leasePushing dismisses the current approval (that's a ruleset setting), so I'll re-approve once the commits show Verified. Auto-merge is enabled, so it merges after that. |
4a2ccb0 to
d25d47a
Compare
d25d47a to
04afc24
Compare
Summary
Added representative previews for File Dropzone, Proximity Sidebar, File Tree, Theme Toggle, Date Range Picker, Stepper, Noise, and Morph Invite. Pixel Card now has visible static content. ComponentCard displays a descriptive fallback if a future component lacks a preview.
Related Issue
Closes #22
Type of Change
Component(s) Affected
src/app/components/page.tsxsrc/components/showcase/component-card.tsxEngineering Quality Checklist
Validation
Compared the renderer map against all 63 published registry entries: no entries are missing. Inspected the rendered gallery: no empty preview containers or fallbacks were present. Gallery previews remain inert so the card's navigation link stays accessible.
The integrated
codex/stagingtree containing this PR passednpm run lint,npm run typecheck,npm run build,npm run check:lockfile, registry synchronization, andgit diff --check. Individual GitHub CI checks remain the merge gate.Visual Demonstration
Screenshots were captured from integrated staging.
Review follow-up
Rechecked the gallery DateRangePicker after #89’s sizing correction. Desktop and 390px mobile both show one complete month with all seven weekday columns; the scaled picker is 244.8px wide with equal internal client and scroll widths (542px), so it fits without internal horizontal overflow. The explicit months={1} preview remains intact. Re-signed the PR history using the existing SSH key.