Skip to content

#82 Fix SQLite.Framework.Bundled failing to build when used together with the SQLite.Framework.DependencyInjection project #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
destbg merged 1 commit into from
Aug 19, 2026
Merged

#82 Fix SQLite.Framework.Bundled failing to build when used together with the SQLite.Framework.DependencyInjection project #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions SQLite.Framework.Base/SQLite.Framework.Base.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
</ItemGroup>

<ItemGroup>
<InternalsVisibleTo Include="SQLite.Framework.DependencyInjection" />
<InternalsVisibleTo Include="SQLite.Framework.Tests" />
<InternalsVisibleTo Include="SQLite.Framework.Tests.Base" />
<InternalsVisibleTo Include="SQLite.Framework.Tests.Bundled" />
Expand Down
1 change: 1 addition & 0 deletions SQLite.Framework.Bundled/SQLite.Framework.Bundled.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
</ItemGroup>

<ItemGroup>
<InternalsVisibleTo Include="SQLite.Framework.DependencyInjection" />
<InternalsVisibleTo Include="SQLite.Framework.Tests" />
<InternalsVisibleTo Include="SQLite.Framework.Tests.Base" />
<InternalsVisibleTo Include="SQLite.Framework.Tests.Bundled" />
Expand Down
1 change: 1 addition & 0 deletions SQLite.Framework.Cipher/SQLite.Framework.Cipher.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
</ItemGroup>

<ItemGroup>
<InternalsVisibleTo Include="SQLite.Framework.DependencyInjection" />
<InternalsVisibleTo Include="SQLite.Framework.Tests" />
<InternalsVisibleTo Include="SQLite.Framework.Tests.Base" />
<InternalsVisibleTo Include="SQLite.Framework.Tests.Bundled" />
Expand Down
54 changes: 54 additions & 0 deletions Tests/SQLite.Framework.Tests/DependencyInjection/InternalsVisibilityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
using System.Reflection;
using System.Runtime.CompilerServices;

namespace SQLite.Framework.Tests;

public class InternalsVisibilityTests
{
[Fact]
public void FrameworkAssemblyKeepsTheSharedAssemblyName()
{
Assert.Equal("SQLite.Framework", typeof(SQLiteDatabase).Assembly.GetName().Name);
}

[Fact]
public void FrameworkAssemblyGrantsInternalsToDependencyInjection()
{
string[] friends = typeof(SQLiteDatabase).Assembly
.GetCustomAttributes<InternalsVisibleToAttribute>()
.Select(a => a.AssemblyName)
.ToArray();

Assert.Contains(friends, name => name == "SQLite.Framework.DependencyInjection");
}

[Fact]
public void MigrationActivatorDelegateIsInternal()
{
Type? type = typeof(SQLiteDatabase).Assembly.GetType("SQLite.Framework.Internals.SQLiteMigrationActivator");

Assert.NotNull(type);
Assert.True(type is { IsPublic: false, IsNotPublic: true });
}

[Fact]
public void MigrationActivatorIsAnInternalProperty()
{
PropertyInfo? property = typeof(SQLiteDatabase).GetProperty("MigrationActivator", BindingFlags.Instance | BindingFlags.NonPublic);

Assert.NotNull(property);
Assert.NotNull(property.GetMethod);
Assert.NotNull(property.SetMethod);
Assert.True(property.GetMethod.IsAssembly);
Assert.True(property.SetMethod.IsAssembly);
}

[Fact]
public void UseMigrationActivatorIsAnInternalMethod()
{
MethodInfo? method = typeof(SQLiteMigrationRunner).GetMethod("UseMigrationActivator", BindingFlags.Instance | BindingFlags.NonPublic);

Assert.NotNull(method);
Assert.True(method.IsAssembly);
}
}
Loading