Add laterite, rock, sand to vector unpaved surface list - #398
Open
julcnx wants to merge 1 commit into
Open
Conversation
vector/tilemaker/process-otm.lua classifies surface into "unpaved" for the streets_med/streets vector layers, but the value list was missing laterite (approved via OSM's proposal process, 29-0-0, https://wiki.openstreetmap.org/wiki/Proposal:Surface=laterite, documented at https://wiki.openstreetmap.org/wiki/Tag:surface=laterite), rock, and sand, all of which are unpaved natural surfaces in the same vein as the dirt/gravel/mud/ground values already in the list. Scoped to just the missing values in this list. The raster renderer (mapnik/opentopomap.xml) doesn't use surface for paved/unpaved styling at all currently, that's a separate, much bigger gap out of scope here.
Author
|
Just wanted to check in on this one. I opened the PR adding laterite, rock, and sand to the vector unpaved surface list in process-otm.lua about three weeks ago, and it's had no comments or reviews yet. No rush at all, just making sure it hasn't slipped off the radar. Happy to adjust the approach if anything about it needs changing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vector/tilemaker/process-otm.luaclassifiessurfaceintounpavedfor thestreets_med/streetsvector layers, but the value list is missing a few common unpaved natural surfaces:laterite,rock, andsand.surface=lateritewas approved via OSM's proposal process (Proposal:Surface=laterite, 29-0-0) and is documented at Tag:surface=laterite. It's a natural lateritic soil surface, in the same vein as thedirt/gravel/mud/groundvalues already in the list.rockandsandare likewise already-common unpaved values that were missing.Changes
vector/tilemaker/process-otm.lua: addlaterite,rock,sandto the unpaved surface value list.Scoped to just this list. I noticed the raster renderer (
mapnik/opentopomap.xml) doesn't usesurfacefor paved/unpaved styling at all currently (onlytracktypeaffects styling there), that's a separate, much bigger gap and out of scope for this PR, flagging it here in case it's useful context.Testing
I don't have a tilemaker build set up locally, so this hasn't been run against real data, it's a one-line addition to an existing value list following the exact same pattern as the other values already there.