add support for experiments - #221
Open
jakecoffman wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds experiment configuration support so proxy features can directly check job-provided experiment flags.
Changes:
- Adds
Experimentsto proxy configuration. - Provides an
Enabledhelper for boolean flags. - Tests parsing, enabled/disabled flags, invalid values, and missing experiments.
Show a summary per file
| File | Description |
|---|---|
internal/config/config.go |
Defines experiment configuration and lookup behavior. |
internal/config/config_test.go |
Verifies parsing and experiment checks. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This adds explicit experiment support. In the past we would have had to add an experiment check in the Action and add an environment variable, and then check that in the Proxy.
With this we can skip the step in the Action and just check the experiments input.
Anything you want to highlight for special attention from reviewers?
No production risk here, if the data isn't sent it gets the "zero value" and is blank.
How will you know you've accomplished your goal?
I have another PR that needs an experiment so that's how I'd know!
Checklist