Skip to content

finances: convert gasbill and mspdf to the new, unified index.ts command#15

Merged
denversc merged 19 commits into
mainfrom
unify
Jun 21, 2026
Merged

finances: convert gasbill and mspdf to the new, unified index.ts command#15
denversc merged 19 commits into
mainfrom
unify

Conversation

@denversc

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the document parsing logic by introducing helper utilities in document_utils.ts and error.ts, and adding dedicated parser classes for Kitchener Utilities bills and Morgan Stanley release confirmations. It also removes the old standalone CLI scripts. The reviewer feedback focuses on improving the robustness of the regular expressions used for parsing (such as handling flexible decimal places, trailing carriage returns, and whitespaces), avoiding mutating function parameters in prefixMessage, and optimizing stringFromLines to prevent double regex execution.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread finances/documents/morgan_stanley.ts
Comment thread finances/documents/morgan_stanley.ts
Comment thread finances/documents/morgan_stanley.ts
Comment thread finances/documents/morgan_stanley.ts
Comment thread finances/documents/kitchener_utilities.ts
Comment thread finances/documents/morgan_stanley.ts
Comment thread finances/documents/kitchener_utilities.ts
Comment thread finances/documents/morgan_stanley.ts
Comment thread finances/document_utils.ts Outdated
Comment thread finances/documents/morgan_stanley.ts
@denversc

Copy link
Copy Markdown
Owner Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the PDF parsing logic by introducing a shared utility module (document_utils.ts) and implementing structured document parsers for Kitchener Utilities bills and Morgan Stanley release confirmations, while removing the legacy standalone scripts. The review feedback focuses on improving the robustness of the regular expressions used for parsing numbers, dates, and amounts (such as making decimal places and parentheses optional) and correcting a truthiness check in the utility function to safely handle empty string matches.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread finances/documents/morgan_stanley.ts
Comment thread finances/documents/morgan_stanley.ts
Comment thread finances/document_utils.ts Outdated
Comment thread finances/documents/morgan_stanley.ts
Comment thread finances/documents/kitchener_utilities.ts
@denversc
denversc merged commit 4f10805 into main Jun 21, 2026
4 checks passed
@denversc
denversc deleted the unify branch June 21, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant