fix(data-structures): support array-like inputs in BinarySearchTree.from() and RedBlackTree.from() - #7314
Open
tomas-zijdemans wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7314 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 617 617
Lines 51637 51637
Branches 9359 9359
=======================================
Hits 49075 49075
Misses 2021 2021
Partials 541 541 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… and pass Deno 1.x type-check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
BinarySearchTree.from()andRedBlackTree.from()for array-like objects without a mapping function. Both acceptArrayLike<T>per their signatures, yetRedBlackTree.from({ 0: 42, length: 1 })threwTypeError: values is not iterable. Same bug in both classes, sinceRedBlackTreeoverridesfrom()with a copy of the parent's logic.Convert unmapped inputs with
Array.from()before insertion. Three regression tests per class cover empty inputs, sorting and deduplication, and a custom comparator. All six previously failed.Validation:
env -u NO_COLOR deno task okon Deno 2.9.6: lint, formatting, browser compatibility, and all tests pass.as ArrayLike<U> | Iterable<U>cast, so the fix now uses theas unknown asidiom already used elsewhere in these files.