Skip to content

fix(async/unstable): ignore stale half-open requests in circuit breaker - #7306

Open
tomas-zijdemans wants to merge 1 commit into
denoland:mainfrom
tomas-zijdemans:fix-cb-half-open-generation
Open

fix(async/unstable): ignore stale half-open requests in circuit breaker#7306
tomas-zijdemans wants to merge 1 commit into
denoland:mainfrom
tomas-zijdemans:fix-cb-half-open-generation

Conversation

@tomas-zijdemans

Copy link
Copy Markdown
Contributor

A request admitted during one half-open period could finish after the circuit had re-opened and gone half-open again. Its success then counted toward the new period, and its cleanup freed a slot the new period never handed out, so a probe got through above halfOpenMaxConcurrent.

Each OPEN → HALF_OPEN transition now bumps a generation counter. A request records the generation at admission, and both its success handling and its in-flight decrement are skipped when the generation has moved on.

Two tests cover the stale close and the leaked slot. Both fail on main.

@github-actions github-actions Bot added the async label Sep 6, 2026
@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.03%. Comparing base (ca58f94) to head (1aa0e99).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7306      +/-   ##
==========================================
- Coverage   95.03%   95.03%   -0.01%     
==========================================
  Files         617      618       +1     
  Lines       51637    51899     +262     
  Branches     9359     9409      +50     
==========================================
+ Hits        49075    49323     +248     
- Misses       2021     2030       +9     
- Partials      541      546       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant