fix(async/unstable): ignore stale half-open requests in circuit breaker - #7306
Open
tomas-zijdemans wants to merge 1 commit into
Open
fix(async/unstable): ignore stale half-open requests in circuit breaker#7306tomas-zijdemans wants to merge 1 commit into
tomas-zijdemans wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7306 +/- ##
==========================================
- Coverage 95.03% 95.03% -0.01%
==========================================
Files 617 618 +1
Lines 51637 51899 +262
Branches 9359 9409 +50
==========================================
+ Hits 49075 49323 +248
- Misses 2021 2030 +9
- Partials 541 546 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A request admitted during one half-open period could finish after the circuit had re-opened and gone half-open again. Its success then counted toward the new period, and its cleanup freed a slot the new period never handed out, so a probe got through above
halfOpenMaxConcurrent.Each OPEN → HALF_OPEN transition now bumps a generation counter. A request records the generation at admission, and both its success handling and its in-flight decrement are skipped when the generation has moved on.
Two tests cover the stale close and the leaked slot. Both fail on main.