Skip to content

test(jsonc): make the JSONTestSuite harness compare parsed values #7303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartlomieju merged 2 commits into from
Sep 17, 2026
+9 −7
Merged

test(jsonc): make the JSONTestSuite harness compare parsed values #7303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3afe9d6
test(jsonc): make the JSONTestSuite harness compare parsed values
tomas-zijdemans Sep 3, 2026
cce6128
Merge branch 'main' into test-jsonc-harness-comparison
bartlomieju Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions jsonc/testdata/JSONTestSuite/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ function getError<T>(

// Make sure that the JSON.parse and JSONC.parse results match.
for await (
const dirEntry of walk(fromFileUrl(new URL("./", import.meta.url)))
const dirEntry of walk(fromFileUrl(new URL("./", import.meta.url)), {
exts: [".json"],
})
) {
if (!dirEntry.isFile) {
continue;
Expand All @@ -30,12 +32,12 @@ for await (
async fn() {
const text = await Deno.readTextFile(dirEntry.path);

const [hasJsonError, jsonError, jsonResult] = getError(() => {
JSON.parse(text);
});
const [hasJsoncError, jsoncError, jsoncResult] = getError(() => {
JSONC.parse(text);
});
const [hasJsonError, jsonError, jsonResult] = getError(() =>
JSON.parse(text)
);
const [hasJsoncError, jsoncError, jsoncResult] = getError(() =>
JSONC.parse(text)
);

// If an error occurs in JSON.parse() but no error occurs in JSONC.parse(), or vice versa, an error is thrown.
if (hasJsonError !== hasJsoncError) {
Expand Down
Loading