Skip to content

fix(jsonc): report unterminated strings as unexpected end of input #7302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomas-zijdemans wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −0
Open

fix(jsonc): report unterminated strings as unexpected end of input #7302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions jsonc/parse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,13 +156,20 @@ class JsoncParser {
// '"\\\\\\""' => '\\"'
// '"\\\\\\\\"' => '\\\\'
let shouldEscapeNext = false;
let hasEndOfString = false;
i++;
for (; i < this.#length; i++) { // read until find `"`
if (this.#text[i] === '"' && !shouldEscapeNext) {
hasEndOfString = true;
break;
}
shouldEscapeNext = this.#text[i] === "\\" && !shouldEscapeNext;
}
if (!hasEndOfString) {
throw new SyntaxError(
"Cannot parse JSONC: unexpected end of JSONC input",
);
}
yield {
type: "String",
sourceText: this.#text.substring(startIndex, i + 1),
Expand Down
10 changes: 10 additions & 0 deletions jsonc/parse_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,16 @@ Deno.test({
SyntaxError,
"Cannot parse JSONC: unexpected end of JSONC input",
);
assertInvalidParse(
`"abc`,
SyntaxError,
"Cannot parse JSONC: unexpected end of JSONC input",
);
assertInvalidParse(
`{"a": "b`,
SyntaxError,
"Cannot parse JSONC: unexpected end of JSONC input",
);
assertInvalidParse(
`[]100`,
SyntaxError,
Expand Down
Loading