reference: fix the orphaned Temporal category nav link#3323
Merged
Conversation
The reference sidebar lists web categories from web-categories.json, but the actual category pages come from the @category tags in the generated type definitions. Temporal carries no @category tag (verified: zero in the generated web.d.ts), so no /api/web/temporal/ page is built, yet the sidebar still linked to it - a 404 on every web reference page. Removing the entry stops the broken link. The Temporal symbols remain fully reachable: they group under 'Other APIs' (uncategorized), the all-symbols index, and search. Giving Temporal its own category needs @category Temporal tags in the upstream Deno web type definitions (web.d.ts is generated, not authored here), which is a separate, larger change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First polish follow-up after the reference flip (#3321).
The reference sidebar builds its web category list from
web-categories.json, but the actual category pages are generated fromthe
@categorytags in the type definitions. Temporal carries no@categorytag - verified: zero occurrences of@category Temporalinthe generated
web.d.ts- so no/api/web/temporal/page is built, yetthe sidebar still linked to it. The result was a 404 on every web
reference page's sidebar.
This removes the orphaned entry so the broken link is gone. The Temporal
symbols are not lost: they remain reachable under "Other APIs"
(uncategorized), in the all-symbols index, and via search.
Auditing confirmed Temporal is the only such orphan (Deno has none), so a
targeted fix is appropriate rather than a broader sidebar refactor.
Giving Temporal its own proper category would need
@category Temporaltags in the upstream Deno web type definitions (
web.d.tsis generatedby the types pipeline, not authored in this repo), which is a separate,
larger change worth doing if Temporal's prominence warrants it.
Verified: reference build green (105 pages), no page links to
/api/web/temporalanymore, andTemporal.PlainDateand friends stillrender on the uncategorized page.