fix(config): preserve other deploy fields when writing org/app#103
Open
velikodniy wants to merge 2 commits into
Open
fix(config): preserve other deploy fields when writing org/app#103velikodniy wants to merge 2 commits into
velikodniy wants to merge 2 commits into
Conversation
Author
|
The tests failed, but it's because the Note that it crashes in the tests added before this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
deno deployupdates theorgandappfields in the config. However, it doesn't preserve other fields in thedeployblock.For example, after running
deno deploythis config:becomes just
Changes
The solution is to update the
organdappfields directly rather than replacing the entiredeployblock.Tests
Since
writeConfigis not exported, the new behaviour is tested via executing the deploy handler.