Skip to content

fix(config): preserve other deploy fields when writing org/app#103

Open
velikodniy wants to merge 2 commits into
denoland:mainfrom
velikodniy:fix-deploy-config-rewrites
Open

fix(config): preserve other deploy fields when writing org/app#103
velikodniy wants to merge 2 commits into
denoland:mainfrom
velikodniy:fix-deploy-config-rewrites

Conversation

@velikodniy

Copy link
Copy Markdown

Summary

Problem

deno deploy updates the org and app fields in the config. However, it doesn't preserve other fields in the deploy block.

For example, after running deno deploy this config:

 "deploy": {
    "org": "my-org",
    "app": "my-app",
    "exclude": [
      "!dist"
    ]
  }

becomes just

  "deploy": {
    "org": "vlcdn",
    "app": "parkruns"
  }

Changes

The solution is to update the org and app fields directly rather than replacing the entire deploy block.

Tests

Since writeConfig is not exported, the new behaviour is tested via executing the deploy handler.

@velikodniy

velikodniy commented Jun 23, 2026

Copy link
Copy Markdown
Author

The tests failed, but it's because the DENO_DEPLOY_TOKEN isn't set. This PR is a fork PR, so the secret is empty.

Note that it crashes in the tests added before this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant