fix: set up default derives#49
Open
Fenex wants to merge 1 commit into
Open
Conversation
Swap default derives for requests and responses structs: - `*Request`: Serialize -> Deserialize - `*Response`: Deserialize -> Serialize
Owner
|
Hi, instead of swapping Serialize and Deserialize, consider adding BOTH traits to support both client and server usage: #[derive(Debug, Clone, Serialize, Deserialize)]This would make the generated models universal without significant overhead. The current change only works for server-side use, while having both traits works for everything. What do you think? |
Contributor
Author
|
I do not use Request/Response structs at all. I just did notice this strange derive and send a PR to fix. But yeah, it is possible to just generate both serde traits for all cases. |
Owner
|
For this one If you add both of the crates - it will be cool. Let's put this aside for a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap default derives for requests and responses structs:
*Request: Serialize -> Deserialize*Response: Deserialize -> Serialize