DLPX-87759 Skip config checks while building the kernel - #299
Merged
palash-gandhi merged 1 commit intoSep 5, 2023
Merged
Conversation
palash-gandhi
force-pushed
the
dlpx/pr/palash-delphix/894e1386-8904-4c99-b516-75e6e9e13ea4
branch
from
September 1, 2023 19:36
186f071 to
c8dad4b
Compare
prakashsurya
reviewed
Sep 1, 2023
prakashsurya
approved these changes
Sep 1, 2023
prakashsurya
left a comment
Contributor
There was a problem hiding this comment.
LGTM pending passing tests.. lets also verify this works with the updated kernel changes you're working on too, before landing..
palash-gandhi
force-pushed
the
dlpx/pr/palash-delphix/894e1386-8904-4c99-b516-75e6e9e13ea4
branch
from
September 1, 2023 20:09
c8dad4b to
8c318ef
Compare
palash-gandhi
marked this pull request as ready for review
September 1, 2023 21:05
Contributor
Author
Thanks, my tests on the other change also passed. http://selfservice.jenkins.delphix.com/job/appliance-build-orchestrator-pre-push/6891/ |
palash-gandhi
enabled auto-merge (squash)
September 2, 2023 04:35
palash-gandhi
force-pushed
the
dlpx/pr/palash-delphix/894e1386-8904-4c99-b516-75e6e9e13ea4
branch
from
September 2, 2023 04:36
8c318ef to
a2cb8d0
Compare
sebroy
approved these changes
Sep 5, 2023
palash-gandhi
deleted the
dlpx/pr/palash-delphix/894e1386-8904-4c99-b516-75e6e9e13ea4
branch
September 5, 2023 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This is a dependent change required for delphix/linux-kernel-aws#46. Please see the problem statement in that PR for context.
Solution
Pass an option to skip the config checks to
updateconfigs.Testing Done
From this build: