DLPX-98314 delphix-kernel: control.aws.in still Depends on linux-modules-extra, which Ubuntu dropped for aws in 7.0 - #22
Open
lyriclake wants to merge 1 commit into
Conversation
…les-extra, which Ubuntu dropped for aws in 7.0 PR URL: https://www.github.com/delphix/delphix-kernel/pull/22
lyriclake
force-pushed
the
dlpx/pr/lyriclake/ae112670-d074-47e7-9b37-079752445050
branch
from
August 5, 2026 20:39
301c20e to
fe74868
Compare
lyriclake
marked this pull request as ready for review
August 5, 2026 20:54
david-mendez1
left a comment
david-mendez1
left a comment
There was a problem hiding this comment.
Looks fine, depending on ab-pre-push
david-mendez1
approved these changes
Aug 5, 2026
dbjwhs-perforce
approved these changes
Aug 5, 2026
dbjwhs-perforce
left a comment
dbjwhs-perforce
left a comment
There was a problem hiding this comment.
LGTM, I see something like this was almost done back in the day PR 20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
appliance-build fails to install the appliance image for linux-kernel-aws#72 (rebase onto Ubuntu-aws-7.0-7.0.0-1009.9_24.04.1):
Ubuntu dropped the modules-extra package split for the aws kernel flavor as of Ubuntu-aws 6.17.0-1002.2 ("aws: Drop leftover modules-extra support"), part of a fleet-wide Canonical initiative tracked by Launchpad bug #2042831. linux-kernel-aws's
debian.aws-7.0template no longer produces alinux-modules-extradeb, butdebian/control.aws.inin this repo still hard-declares aDepends:onlinux-modules-extra-@@KVERS@@, so apt can never satisfy the dependency for this kernel version.Solution
Remove
linux-modules-extra-@@KVERS@@from theDepends:list indebian/control.aws.inonly.control.oracle.in,control.gcp.in,control.azure.in, andcontrol.generic.inare intentionally left untouched — those flavors' Ubuntu bases still ship the modules-extra split today. Removing the dependency preemptively for those flavors would be a silent functional regression, since apt would simply stop requiring a package that still exists rather than erroring, so driver/module content would quietly stop being installed by default until something broke in the field. Each other flavor should get this same treatment only once its own base tag actually drops the split.Testing Done
Validated with
git ab-pre-pushusing--extra-repoto combine this fix branch with the existing linux-kernel-aws#72 patchset and the zfs sockaddr_unsized fix (delphix/zfs#2305, DLPX-98297), rerunning the full appliance-build-orchestrator-pre-push. This confirms both the aws rebase and this dependency fix together get past the build stage.ab-pre-push build #14734: IN PROGRESS
linux-kernel-aws@69ffacf47d20(#72),delphix-kernel@fe74868(this PR),zfs@e62b28d4bbc4(#2305) (againstdevelop)