[mikehorgan-dell]

Summary

With --slice-endpoints (engine storage.net.node.slice), the nodes of a distributed run, the entry node included, split into groups, and each group targets its own share of the endpoints. When the node count did not divide the endpoint count, the groups were computed correctly but assigned to the wrong nodes. Only the first nodes got a share, one each, and the later nodes kept every endpoint, although the log listed a group for each node:

• 4 nodes, 2 endpoints: the first two nodes got one endpoint each, and the third and fourth targeted both.
• 4 nodes, 6 endpoints: the third and fourth nodes targeted all six.

Each node now targets the group the log lists for it. With 4 nodes and 2 endpoints, the first two target the first endpoint and the last two the second.

Unchanged:

• runs whose node count divides the endpoint count;
• runs whose two counts share no factor, where every node still targets every endpoint.

Changes

• ConfigSliceUtil.sliceStorageNodeAddrs: assigns group i to node slice j, the slice its log line already names, instead of to slice i. It is a one-line fix. The only caller is LoadStepClientBase.sliceConfig, for the base configuration and each context configuration.
• CHANGELOG.md: an Unreleased → Fixed entry.

Testing

• ConfigSliceUtilTest.sliceStorageNodeAddrsAssignsEverySliceItsGroup: a parameterized test over (nodes, endpoints) = (1,1), (2,4), (4,2), (4,4), (4,6), (3,2), (2,3), asserting every slice's storage-net-node-addrs.
  • With the old assignment restored, (4,2) and (4,6) fail and the other five pass.
  • (3,2) and (2,3) share no factor, so keeping every endpoint is the expected result there.
• Engine: 3,049 tests, 0 failures, 9 skipped. Spotless, strict Error Prone on spt-base and :bundle:assembleDist pass.
• Not run: a distributed lab run. The change is confined to the slice assignment, which the test table covers directly.