Repository navigation
Remove slurm_preferred_addr_family (ER-ORCH-005 FR-7 violation) - #5674
Open
sujit-jadhav wants to merge 1 commit into
Open
sujit-jadhav wants to merge 1 commit into
sujit-jadhav wants to merge 1 commit into
Conversation
sujit-jadhav
requested review from
RvishankarOMnia,
VenkateswaraVatam,
abhishek-sa1 and
snarthan
as code owners
November 1, 2026 13:56
Remove the slurm_preferred_addr_family configuration variable which contradicts ER-ORCH-005 FR-7. FR-7 states that in dual-stack mode, NodeAddr must automatically use IPv6 — no operator choice. The actual NodeAddr injection logic (inject_ib_nodeaddr.yml) already correctly implements FR-7 by preferring IB_IPV6 and falling back to IB_IPV4. The variable was dead configuration that was never referenced by the injection logic. Changes: - network_spec.yml: Replace slurm_preferred_addr_family comments with FR-7 behavior documentation, remove the variable from the example - network_spec.json: Remove slurm_preferred_addr_family from both schema variants (ipv4_subnet and legacy subnet) - test_slurm_nodeaddr_ipv6.py: Remove derive_nodeaddr_af preference param, remove validate_dual_stack_preference and detect_preference_mismatch helpers and their test classes - test_backward_compat_ipv6.py: Replace schema presence assertion with absence assertion (field must not exist) - _pxeboot_helpers.py: Simplify resolve_ib_addr_family to return ipv6 for dual-stack per FR-7 Fixes #5398 Signed-off-by: Sujit Jadhav <sujit.jadhav@dell.com>
sujit-jadhav
force-pushed
the
fix/remove-slurm-preferred-addr-family
branch
from
November 1, 2026 14:18
a871eb3 to
fe641a3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5398
Remove the
slurm_preferred_addr_familyconfiguration variable which contradicts ER-ORCH-005 FR-7:Per FR-7, dual-stack mode must automatically use IPv6 — no operator choice.
Root Cause
The actual NodeAddr injection logic (
roles/slurm_config/tasks/inject_ib_nodeaddr.yml) already correctly implements FR-7 — it prefersIB_IPV6and falls back toIB_IPV4. Theslurm_preferred_addr_familyvariable was dead configuration that was never referenced by the injection logic.Changes
input/network_spec.yml: Replaceslurm_preferred_addr_familycomments with FR-7 behavior documentation, remove the variable from the exampleib_networksectionschema/network_spec.json: Removeslurm_preferred_addr_familyfrom both schema variants (ipv4_subnetand legacysubnet)Verification
Returns zero results after this change.