Skip to content

fix: FastembedLateInteractionRanker reordered the top_k fallback to happen after validation - #3746

Merged
davidsbatista merged 1 commit into
mainfrom
fix/fastembed-late-interaction-ranker-top-k-zero
Aug 10, 2026
Merged

fix: FastembedLateInteractionRanker reordered the top_k fallback to happen after validation#3746
davidsbatista merged 1 commit into
mainfrom
fix/fastembed-late-interaction-ranker-top-k-zero

Conversation

@davidsbatista

Copy link
Copy Markdown
Contributor

Related Issues

Proposed Changes:

  • reordered the top_k fallback to happen after validation

How did you test it?

  • one new test

Checklist

@github-actions github-actions Bot added integration:fastembed type:documentation Improvements or additions to documentation labels Aug 7, 2026
@davidsbatista
davidsbatista marked this pull request as ready for review August 7, 2026 16:17
@davidsbatista
davidsbatista requested a review from a team as a code owner August 7, 2026 16:17
@davidsbatista
davidsbatista requested review from sjrl and removed request for a team August 7, 2026 16:17
@davidsbatista davidsbatista changed the title fix: reordered the top_k fallback to happen after validation, and added re… fix: FastembedLateInteractionRanker reordered the top_k fallback to happen after validation Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Coverage report (fastembed)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/fastembed/src/haystack_integrations/components/rankers/fastembed
  late_interaction_ranker.py
Project Total  

This report was generated by python-coverage-comment-action

@sjrl sjrl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@davidsbatista
davidsbatista merged commit 02558f1 into main Aug 10, 2026
20 checks passed
@davidsbatista
davidsbatista deleted the fix/fastembed-late-interaction-ranker-top-k-zero branch August 10, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:fastembed type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants