fix: FastEmbedder reordered the top_k fallback to happen after validation - #3745
Merged
Conversation
github-actions
Bot
added
integration:fastembed
type:documentation
davidsbatista
marked this pull request as ready for review
August 7, 2026 16:15
Contributor
Coverage report (fastembed)
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
anakin87
reviewed
Aug 10, 2026
| ): | ||
| ranker.run(query=query, documents=list_document, top_k=0) | ||
|
|
||
| def test_run_runtime_top_k_zero_does_not_fall_back_to_instance_top_k(self): |
Member
There was a problem hiding this comment.
this test is, in practice, a duplicate of the assertion above. In fact, by default FastembedRanker has top_k=10, so I'd remove this test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.