Skip to content

fix: IBMDB adding optional parameter filters to get_metadata_field_unique_values() - #3739

Merged
davidsbatista merged 1 commit into
mainfrom
ibm_db-add-filters-to-unique-values
Aug 10, 2026
Merged

fix: IBMDB adding optional parameter filters to get_metadata_field_unique_values()#3739
davidsbatista merged 1 commit into
mainfrom
ibm_db-add-filters-to-unique-values

Conversation

@davidsbatista

Copy link
Copy Markdown
Contributor

Proposed Changes:

  • adding optional parameter filters to get_metadata_field_unique_values()

How did you test it?

  • added one more test to check filters usage

@github-actions github-actions Bot added integration:ibm-db type:documentation Improvements or additions to documentation labels Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Coverage report (ibm_db)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/ibm_db/src/haystack_integrations/document_stores/ibm_db
  document_store.py 638-639
Project Total  

This report was generated by python-coverage-comment-action

@davidsbatista
davidsbatista marked this pull request as ready for review August 6, 2026 11:34
@davidsbatista
davidsbatista requested a review from a team as a code owner August 6, 2026 11:34
@davidsbatista
davidsbatista requested review from sjrl and removed request for a team August 6, 2026 11:34

@sjrl sjrl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@davidsbatista
davidsbatista merged commit beb967b into main Aug 10, 2026
16 checks passed
@davidsbatista
davidsbatista deleted the ibm_db-add-filters-to-unique-values branch August 10, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:ibm-db type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants