feat/microsoft-sharepoint: add region parameter to MSSharePointRetriever - #3722
Conversation
|
Hi @SyedShahmeerAli12, thanks for your interest in contributing to Haystack! 🙏 This is an automated message to help us keep the review queue healthy. |
|
Heads-up for maintainers This PR is from a fork and touches integrations whose integration tests require API keys. Affected integrations:
Please run the integration tests locally ( |
Coverage report (microsoft_sharepoint)Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
bogdankostic
left a comment
There was a problem hiding this comment.
Thanks @SyedShahmeerAli12! Looks good in general, just a few minor comments.
bogdankostic
left a comment
There was a problem hiding this comment.
Looks good, thanks for addressing the feedback so quickly @SyedShahmeerAli12!
Summary
Closes #3673
region: str | None = Noneinit parameter toMSSharePointRetrieverregionfield is included in the Microsoft Search API request body400: Region is required when request with application permissionNone(default), preserving existing delegated-auth behaviorto_dict/from_dictTest plan
test_defaultsassertsregion is Noneby defaulttest_to_dictassertsregion: Nonein serialized outputtest_to_dict_with_regionassertsregion: "US"serializes correctlytest_region_included_in_request_body_when_setverifiesregionappears in the HTTP POST bodytest_region_omitted_from_request_body_when_none—verifiesregionkey is absent when not setTestLiveAppOnlyintegration test class for real app-only auth (skipped unlessMS_SHAREPOINT_TENANT_ID,MS_SHAREPOINT_CLIENT_ID,MS_SHAREPOINT_CLIENT_SECRETenv vars are set)ruff check+ruff format)