feat: OpenSearchDocumentStore emulating offset with cursor - #3692
Merged
Conversation
github-actions
Bot
added
integration:opensearch
type:documentation
Contributor
Coverage report (opensearch)
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sjrl
reviewed
Aug 10, 2026
Comment on lines
+2172
to
+2174
| **Note**: To keep this signature uniform across document stores, offset-based pagination is | ||
| emulated on top of the cursor by re-fetching and discarding every bucket before `from_` on each | ||
| call, requiring additional search round-trips proportional to `from_`. |
Contributor
There was a problem hiding this comment.
Lets also add a note along the lines of "Performance may degrade for high-cardinality metadata fields and large from_ values." to make it clear that we don't expect this method to work well on metadata values that have lots of unique values.
sjrl
reviewed
Aug 10, 2026
| metadata_field: str, | ||
| search_term: str | None = None, | ||
| from_: int = 0, | ||
| size: int = 10, |
Contributor
There was a problem hiding this comment.
Do you plan on adding the filters param in a future PR?
Contributor
Author
There was a problem hiding this comment.
Yes coming up next.
sjrl
approved these changes
Aug 10, 2026
sjrl
left a comment
sjrl
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just two minor comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.