feat: ElasticsearchDocumentStore with offset pagination - #3691
Open
davidsbatista wants to merge 12 commits into
Open
feat: ElasticsearchDocumentStore with offset pagination#3691davidsbatista wants to merge 12 commits into
ElasticsearchDocumentStore with offset pagination#3691davidsbatista wants to merge 12 commits into
Conversation
github-actions
Bot
added
integration:elasticsearch
type:documentation
Contributor
Coverage report (elasticsearch)
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sjrl
reviewed
Aug 10, 2026
Comment on lines
-1860
to
-1861
| of the metadata field's own value (not the document content). NOTE: The matching is done with a server-side | ||
| script to accomplish the substring matching on the value of the field and this operation is quite expensive |
Contributor
There was a problem hiding this comment.
Could we bring back this note to the method?
sjrl
reviewed
Aug 10, 2026
| metadata_field: str, | ||
| search_term: str | None = None, | ||
| from_: int = 0, | ||
| size: int = 10, |
Contributor
There was a problem hiding this comment.
do you plan on adding the filter param in a separate PR?
Contributor
Author
There was a problem hiding this comment.
since this one is not approved yet I can add it here already, if you're OK with it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.