A pack relation is a state by construction - #597
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes one decision record only — the status line of 0031. No code.
#593 made corpus-grown relations take
temporalfrom the proposal. The next cut was going to classify the relations that ontology packs bring in — OWL import writes'state'for every property, and packs are the cold start (0008), so most relations in a real base come from there. Before writing that cut the five packs were measured:The 16 with event-like names (
acquiredFrom,publishedBy,releasedEvent, …) are, on reading their comments, all states pointing at an agent or an event node. Standard vocabularies reify an event as a class (PublicationEvent,prov:Generation); their object properties are states by construction. IOF writes the temporal semantics into the property name, and its…AtAllTimesfamily is a candidate foreternal, notevent; it is left alone.So
create_relation_types_bulkwritingstateis right by construction, not an omission. Event relations come from the corpus (#593) and from a person on the ontology page — and sinceworld_axislooks the predicate'stemporalup at read time, a change there takes effect on existing rows at once, with no migration. Recorded so that nobody comes back in six months to "fill in" this cut.🤖 Generated with Claude Code