A script whose usage line says ./ is executable - #591
Merged
WaylandYang merged 1 commit intoSep 10, 2026
Merged
Conversation
Signed-off-by: Menglin Li <limenglin5911@gmail.com>
lml2468
force-pushed
the
fix/a-script-whose-usage-says-dot-slash-is-executable
branch
from
September 10, 2026 11:17
4053a73 to
a689f35
Compare
WaylandYang
approved these changes
Sep 10, 2026
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
Both scripts carry a bash shebang and a usage line that says ./; a mode change is the whole fix, and these are the only two shell scripts under scripts/, so nothing is left behind. Thanks for checking it against a live deployment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both shell scripts under
scripts/carry a shebang and document themselves as being run directly:Neither is committed with the executable bit, so following those lines gives:
You have to know to type
bash scripts/smoke.shinstead — a small stumble, but it lands on someone verifying a fresh deployment, which is exactly when you want the documented command to just work.Mode change only,
100644 → 100755, no content touched.e2e_type_drift.shis included because it has the identical problem; say the word and I'll split it out.Verified after the change:
./scripts/smoke.shruns and passes against a localdocker compose --profile appdeployment.