Skip to content

A script whose usage line says ./ is executable - #591

Merged
WaylandYang merged 1 commit into
deeplethe:devfrom
lml2468:fix/a-script-whose-usage-says-dot-slash-is-executable
Sep 10, 2026
Merged

A script whose usage line says ./ is executable#591
WaylandYang merged 1 commit into
deeplethe:devfrom
lml2468:fix/a-script-whose-usage-says-dot-slash-is-executable

Conversation

@lml2468

@lml2468 lml2468 commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Both shell scripts under scripts/ carry a shebang and document themselves as being run directly:

# 用法: ./scripts/smoke.sh [BASE_URL]  (默认 http://localhost:1516)
# 用法: ./scripts/e2e_type_drift.sh

Neither is committed with the executable bit, so following those lines gives:

$ ./scripts/smoke.sh
zsh: permission denied: ./scripts/smoke.sh

You have to know to type bash scripts/smoke.sh instead — a small stumble, but it lands on someone verifying a fresh deployment, which is exactly when you want the documented command to just work.

Mode change only, 100644 → 100755, no content touched. e2e_type_drift.sh is included because it has the identical problem; say the word and I'll split it out.

Verified after the change: ./scripts/smoke.sh runs and passes against a local docker compose --profile app deployment.

Signed-off-by: Menglin Li <limenglin5911@gmail.com>
@lml2468
lml2468 force-pushed the fix/a-script-whose-usage-says-dot-slash-is-executable branch from 4053a73 to a689f35 Compare September 10, 2026 11:17

@WaylandYang WaylandYang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both scripts carry a bash shebang and a usage line that says ./; a mode change is the whole fix, and these are the only two shell scripts under scripts/, so nothing is left behind. Thanks for checking it against a live deployment.

@WaylandYang
WaylandYang merged commit e0d9383 into deeplethe:dev Sep 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants