Skip to content

An else branch that only holds an if is written as an else-if #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lml2468 wants to merge 1 commit into from
Closed

An else branch that only holds an if is written as an else-if #590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 18 additions & 22 deletions crates/utopia-store/src/temporal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,35 +121,31 @@ pub async fn reconcile_new_fact(
if new_confidence < AUTO_CLOSE_MIN_CONFIDENCE {
record_conflict(pool, kb_id, old.id, new_fact_id, "low_confidence").await?;
report.conflicts += 1;
} else {
if let Some(id) = close_superseded(
pool,
new_fact_id,
of,
old.valid_from_precision.as_deref().unwrap_or("day"),
)
.await?
{
report.corrected.push(id);
}
} else if let Some(id) = close_superseded(
pool,
new_fact_id,
of,
old.valid_from_precision.as_deref().unwrap_or("day"),
)
.await?
{
report.corrected.push(id);
}
}
// 常规接替：旧事实闭合在新事实的开始（旧事实无起点也适用——起点未知但已结束）
(_, Some(nf)) => {
if new_confidence < AUTO_CLOSE_MIN_CONFIDENCE {
record_conflict(pool, kb_id, old.id, new_fact_id, "low_confidence").await?;
report.conflicts += 1;
} else {
if let Some(id) = close_superseded(
pool,
old.id,
nf,
new_validity.from_precision.unwrap_or("day"),
)
.await?
{
report.corrected.push(id);
}
} else if let Some(id) = close_superseded(
pool,
old.id,
nf,
new_validity.from_precision.unwrap_or("day"),
)
.await?
{
report.corrected.push(id);
}
}
}
Expand Down
Loading