fix(docker): include experiments/ in builder so workspace manifest parses#235
Merged
Conversation
…rses The Dockerfile only COPYed `crates ./crates`, but the workspace `Cargo.toml` lists `experiments/v0.4-*` as members. Cargo refuses to parse the workspace manifest without their per-crate manifests present, so `cargo build --release --bin forkd-controller` died with 'No such file or directory' on `experiments/v0.4-uffd-wp-poc/Cargo.toml'. This broke `release.yml`'s `build + push Docker image` job from v0.5.0 through v0.5.2 — the tarball, PyPI, and npm publishes all succeeded, but the ghcr.io controller image was never pushed. Fix: COPY the experiments dir into the builder. They're not selected by `--bin forkd-controller` so they don't compile, but cargo can now parse the manifest. Adds ~100 KB of source to the builder stage; the final runtime image is unchanged. Verified on dev box: image builds clean (152 MB), forkd-controller 0.5.2 runs from the image. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Dockerfile only copied
crates ./cratesinto the builder stage, but the workspaceCargo.tomllistsexperiments/v0.4-*as members. Cargo refuses to parse the workspace manifest without their per-crate manifests present, socargo build --release --bin forkd-controllerdied withNo such file or directoryonexperiments/v0.4-uffd-wp-poc/Cargo.toml.This broke
release.yml'sbuild + push Docker imagejob from v0.5.0 through v0.5.2 — the tarball, PyPI, and npm publishes all succeeded each release, but the ghcr.io controller image was never pushed.Fix
Add
COPY experiments ./experimentsto the builder stage. Experiments aren't selected by--bin forkd-controllerso they don't compile; cargo just needs them present to parse the workspace.Verification (dev box)
Test plan
🤖 Generated with Claude Code