Skip to content

fix: CVE-2026-50593 integer underflow in slotat macro#3

Merged
Zeno-sole merged 1 commit into
masterfrom
fix-cve-2026-50593
Jun 10, 2026
Merged

fix: CVE-2026-50593 integer underflow in slotat macro#3
Zeno-sole merged 1 commit into
masterfrom
fix-cve-2026-50593

Conversation

@hudeng-go

Copy link
Copy Markdown
Contributor

Summary

CVE-2026-50593: Graphite before 1.3.15 has an integer underflow and resultant out-of-bounds write via Graphite actions, because slotat does not ensure that an offset is within the allowed slot-map range.

Changes

  • Add upstream bounds check to the slotat macro in src/inc/opcodes.h
  • The fix ensures the offset is within the valid slot-map range before access

Patch

Upstream commit: silnrsi/graphite@ad78c6b

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

TAG Bot

TAG: 1.3.14-2deepin1
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hudeng-go. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment thread debian/changelog Outdated
@@ -1,3 +1,13 @@
graphite2 (1.3.14-2+deepin1) unstable; urgency=medium

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not acceptable.

Comment thread debian/changelog Outdated
prior to the slotmap. Add upstream patch to add bounds checking to
the slotat macro.

-- 胡登 <ut000081@golf66work> Tue, 09 Jun 2026 09:48:53 +0800

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@hudeng-go hudeng-go force-pushed the fix-cve-2026-50593 branch from b6293a3 to 34a696b Compare June 10, 2026 06:21
Crafted Graphite actions can induce an integer underflow in the slotat
macro, leading to an out-of-bounds write prior to the slotmap.

Add upstream patch to add bounds checking to the slotat macro.

Co-Authored-By: hudeng <hudeng@deepin.org>
Generated-By: deepseek-v4-flash
@hudeng-go hudeng-go force-pushed the fix-cve-2026-50593 branch from 34a696b to 7dc3de4 Compare June 10, 2026 06:23
@hudeng-go

Copy link
Copy Markdown
Contributor Author

/integrate

@github-actions

Copy link
Copy Markdown

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#4143
PrNumber: 4143
PrBranch: auto-integration-27257712675

@Zeno-sole Zeno-sole merged commit 603e299 into master Jun 10, 2026
7 of 9 checks passed

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

怎么没把测试带上

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants