chore(deps): fix npm audit vulnerabilities#2666
Open
mofojed wants to merge 4 commits intodeephaven:mainfrom
Open
chore(deps): fix npm audit vulnerabilities#2666mofojed wants to merge 4 commits intodeephaven:mainfrom
mofojed wants to merge 4 commits intodeephaven:mainfrom
Conversation
- Bump nanoid to ^5.1.9 across packages - Bump vite to ^7.0.0 and sass to ^1.70.0 - Bump jest-environment-jsdom to ^30.0.0 - Bump pouchdb-browser and pouchdb-find to ^9.0.0 - Add overrides for transitive jsdom, uuid, and nx-related vulns (brace-expansion, follow-redirects, yaml)
- Pin @react-spectrum/* and @spectrum-icons/* sub-packages via npm overrides to prevent duplicate @adobe/react-spectrum installs (fixes 'No root provider found' error in TabPanels test) - Update color tests to expect rgb() format (jsdom 26 normalizes named colors) - Replace direct window.location.search assignment with window.history.pushState (jsdom 26 makes location read-only) - Update TimeInput backspace test expectation for jsdom 26 behavior - Remove ColorUtils.isDark invalid color test (jsdom 26 normalizes empty to rgba(0, 0, 0, 0) instead of empty string)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2666 +/- ##
==========================================
- Coverage 49.79% 49.78% -0.01%
==========================================
Files 774 774
Lines 43901 43917 +16
Branches 11125 11129 +4
==========================================
+ Hits 21860 21864 +4
- Misses 22023 22035 +12
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vbabich
reviewed
May 1, 2026
| }, | ||
| "jsdom": "^26.1.0", | ||
| "uuid": "^14.0.0", | ||
| "@react-spectrum/accordion": "3.0.9", |
Collaborator
There was a problem hiding this comment.
That's a lot of react-spectrum overrides. What are they for, and when can we delete them?
Member
Author
There was a problem hiding this comment.
Yea now that they're locked into the package-lock.json, don't think I need to keep the explicit overrides in here... removing.
Collaborator
|
Typecheck is failing on this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(brace-expansion, follow-redirects, yaml)