Skip to content

docs: DOC-752 copies changelog on docs build and adds to sidebar menu#1345

Open
dsmmcken wants to merge 2 commits intomainfrom
dmckenzie_changelog
Open

docs: DOC-752 copies changelog on docs build and adds to sidebar menu#1345
dsmmcken wants to merge 2 commits intomainfrom
dmckenzie_changelog

Conversation

@dsmmcken
Copy link
Copy Markdown
Contributor

@dsmmcken dsmmcken commented May 5, 2026

Copies the changelog during sphinx build step into the docs for publishing. Adds it to the sidebar. Downside of this approach is that page 404s in local render, but this seems like the easiest way to implement.

During this change I discovered our cog template wasn't actually being used. The default template had some invalid JSX in the form of html style="" spans around the word breaking. When I went to remove that I discovered our template wasn't actually being used at all.

cog bump --package changelog uses the package_template which was unset, so our template was never actually used. I made additional changes to the template to correct whitespace in output, and add PR links, and adjust the output heading.

Finally, I added a script that can regen the changelog, to back fix all the old changelog entries.

Downside of this approach is it will be broken in local render.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

ui docs preview (Available for 14 days)

…te was never actually used. Further, change the template to correct whitespace in output, and add PR links.

We did this because the default template outputs some html for breaking changes which was invalid JSX, which how I discovered it wasn't using the template at all.

Finally added a script that can regen the changelog, to fix all the old changelog entries.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

ui docs preview (Available for 14 days)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

plotly-express docs preview (Available for 14 days)

@dsmmcken dsmmcken requested review from mattrunyon and mofojed May 5, 2026 18:26
@dsmmcken dsmmcken changed the title docs: copies changelog on docs build and adds to sidebar menu DOC-752: docs: copies changelog on docs build and adds to sidebar menu May 5, 2026
@dsmmcken dsmmcken changed the title DOC-752: docs: copies changelog on docs build and adds to sidebar menu docs: DOC-752 copies changelog on docs build and adds to sidebar menu May 5, 2026
f"cp -r docs/_assets {BUILT_DOCS}/_assets",
f"[ -d docs/snapshots ] && cp -r docs/snapshots {BUILT_DOCS}/snapshots",
f"cp docs/sidebar.json {BUILT_DOCS}/sidebar.json",
f"[ -f CHANGELOG.md ] && cp CHANGELOG.md {BUILT_DOCS}/changelog.md || true",
Copy link
Copy Markdown
Collaborator

@mattrunyon mattrunyon May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can make this work with local preview (if you wanted) by adding a symlink for the changelog in the docs/src. Not sure if that would break the build, but since you're copying the src file it should be fine?

Comment on lines +1 to +2
#!/usr/bin/env bash
# Regenerate plugins/<package>/CHANGELOG.md from scratch by replaying every
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file needed? We shouldn't need to regenerate it again, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, probably not, but I figured I would leave it in case we ever needed to generate it locally or something.

Comment thread cog.toml
Comment on lines 61 to +68
{ username = "jnumainville", signature = "Joe Numainville" },
{ username = "jnumainville", signature = "Joe" },
{ username = "mofojed", signature = "Mike Bender" },
{ username = "mofojed", signature = "mikebender" },
{ username = "devinrsmith", signature = "Devin Smith" },
{ username = "mattrunyon", signature = "Matt Runyon" },
{ username = "mattrunyon", signature = "Matthew Runyon" },
{ username = "vbabich", signature = "Vlad Babich" },
{ username = "dsmmcken", signature = "Don" },
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several authors had duplicated entries with a different display name (signature)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 several authors have committed to the repo with different git.config names. These are ones Claude discovered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants