fix(ci): unblock frontend CI (unused import + dev-dep audit) - #70
Merged
Merged
Conversation
Frontend CI has been red on every frontend PR, which is why even safe Dependabot patch/minor PRs could not merge: - Lint and Test: `home.tsx` still imported `Activity` after the redesign replaced that badge icon with the animated ping dot. eslint's no-unused-vars made it a hard error. Removed the import. - Security Scan: `npm audit --audit-level=high` audited dev dependencies, so dev-only advisories (vite, picomatch) failed the gate. These never ship to users and are often only fixable via breaking majors. Now audits production deps only (`--omit=dev`), matching the Security Scan in deploy.yml. Verified locally: lint exit 0 (0 errors), npm audit exit 0, build passes.
deep60
enabled auto-merge (squash)
July 16, 2026 04:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend CI was red on every frontend PR — which is why even the safe Dependabot patch/minor PRs (#43 grouped, #19 patch, #20 minor) couldn't merge. Two independent, pre-existing bugs:
Lint and Test—home.tsxstill importedActivityafter the redesign replaced that badge icon with the animated ping dot. eslintno-unused-varsmade it a hard error (1 error, 9 warnings). My regression from the redesign — removed.Security Scan—npm audit --audit-level=highaudited dev dependencies, so dev-only advisories (vite, picomatch) failed the gate. Dev tooling never ships to users and these are often only fixable via breaking majors. Now--omit=dev, matching the Security Scan gate indeploy.yml.Verified locally: lint exit 0 (0 errors), npm audit exit 0, build passes.