fix(sherpa-onnx.rn): add missing dpdfnet field to OfflineSpeechDenoiserModelConfig (Android SIGABRT)#412
Open
brainlybai wants to merge 1 commit into
Conversation
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fixes #411. On Android,
OfflineSpeechDenoiser.newFromFileaborts the process with SIGABRT under CheckJNI because the native JNI callsGetFieldID("dpdfnet", "Lcom/k2fsa/sherpa/onnx/OfflineSpeechDenoiserDpdfNetModelConfig;")onOfflineSpeechDenoiserModelConfig, but the Kotlin data class doesn't declare that field.This PR adds the missing
OfflineSpeechDenoiserDpdfNetModelConfigdata class and thedpdfnetfield onOfflineSpeechDenoiserModelConfig, matching upstream sherpa-onnx Java bindings.Crash (before)
Test plan
sherpa-onnx/jni/speech-denoiser.ccqueries thedpdfnetfield unconditionallylibsherpa-onnx-jni.soshipped in 1.3.1-beta.1 referencesdpdfnet(binary grep)pnpm patch— denoiser init no longer abortsNotes
ios/handlers/and doesn't reflect on Kotlin classes.OfflineSpeechDenoiserDpdfNetModelConfig(), so existing GTCRN-only callers are not affected at runtime.