chore: merge master, release 0.43.8-dc.2, document releasing - #9
Merged
Merged
Conversation
After a successful daemon-mode mount the process closes stdout/stderr, so Go runtime panics and fatal errors vanish without a trace; syslog only carries logger output. Arm debug.SetCrashOutput with an append-only file (default /var/log/geesefs-crash.log, GEESEFS_CRASH_LOG to override) before closing stderr, with a pid/bucket/mountpoint header line so a following dump can be attributed to its mount.
Picks up the daemon-mode crash-log feature from #7, which was merged into master rather than dev, so it was absent from the release line. Merges master into dev the same way #5 did, then bumps the version. Also refreshes the release workflow's dispatch default, which otherwise still offers the previous version.
The release version is a dispatch parameter, so editing the workflow to change it is unnecessary churn. That is also how the default drifted: it sat at 0.43.0-dc.1 while the shipped constant had moved on. Removes the default outright rather than bumping it. It duplicated GEESEFS_VERSION and went stale the moment that constant moved; the input is already required, so dispatch prompts for it. Documents in CLAUDE.md the branch model (dev is the release line, master mirrors upstream, fork work on master is missing from releases), the release commands, and the compute-amis pin that a new release has to follow.
alexsavio
changed the title
Makes dev the documented trunk for all dectris development, and master a read-only mirror that must always sit on the exact upstream commit the fork is based on, with the command to verify that invariant. Spells out the failure mode behind #7: a PR against master leaves its content absent from dev, and a release cut afterwards ships without it while nothing fails. Records the recovery, and notes that the pre-rebase branches still on the remote are superseded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
masterintodevto pick up feat: write runtime crash output to a file in daemon mode #7, which was merged intomasterrather thandevand so was absent from the release line. A release cut before this would have silently shipped without the daemon crash-log feature. Clean merge: feat: write runtime crash output to a file in daemon mode #7 only touchesmain.go,main_nowindows.go,main_windows.go.GEESEFS_VERSIONto0.43.8-dc.2.compute-amispin inCLAUDE.md, and removes the release workflow'sversiondefault. That default duplicatedGEESEFS_VERSIONand had drifted to0.43.0-dc.1, so a UI dispatch would have tagged a release nine patches stale. The input is already required, so dispatch prompts for it.Verified on the merged tree:
go build ./...andgo vetclean, 62 symlinks unit tests pass, zizmor reports no findings.Worth deciding separately:
masteris now upstream 0.43.8 plus one dectris commit, so it is no longer the clean upstream mirror it was after the rebase. Either fork work lands ondevonly, or the mirror role moves elsewhere.