ci: fail pull requests that target master - #11
Merged
Merged
Conversation
master mirrors yandex-cloud/geesefs and must never carry a dectris change. A PR against it is always a mistake: the content ends up absent from dev, and a release cut afterwards silently ships without it, which is what happened with #7 and was only caught by chance. Branch protection is the real enforcement but needs org admin, which is not available here. This at least makes the mistake loud at PR time. Upstream syncs push to master directly rather than through a PR, so this does not interfere with them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mastermirrorsyandex-cloud/geesefsand must never carry a dectris change. A PR against it is always a mistake: the content ends up absent fromdev, and a release cut afterwards silently ships without it. That is what happened with #7, and nothing failed to signal it.Adds a workflow that runs only on PRs targeting
masterand fails immediately with a message pointing atdev.This is a stand-in, not real enforcement. Branch protection on
masteris the proper fix but needs org admin, which I do not have. Without a required-status-check rule this cannot block a merge, only make the mistake visible as a red check. Worth replacing with branch protection when an admin is available.Upstream syncs push to
masterdirectly rather than through a PR, so this does not interfere with them.