fix(ci): create the release tag on the built commit, document tag-based releases - #10
Merged
Merged
Conversation
softprops/action-gh-release defaults target_commitish to the repository's default branch when the tag does not already exist. That branch is the upstream mirror, so v0.43.8-dc.2 was created on plain upstream source: no core/symlinks.go, and GEESEFS_VERSION reading 0.43.8 rather than 0.43.8-dc.2, while the uploaded binary was correctly built from dev. Pin the tag to the commit the workflow actually built. The bug was latent until now because previous releases had their tag pushed beforehand, so the action attached to an existing ref instead of creating one.
Pushing a tag is the safer path: the tag is created deliberately at a known commit, the workflow builds from that same ref, and the release action attaches to an existing tag instead of choosing where to put one. That removes the failure this branch fixes, and publishes a full release without a promote step. Keeps manual dispatch documented as the fallback for when a tag push does not trigger, with the prerelease caveat spelled out.
alexsavio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
softprops/action-gh-releasedefaultstarget_commitishto the repository's default branch when the tag does not already exist. That branch ismaster, the upstream mirror, so the tag forv0.43.8-dc.2was created on plain upstream source: nocore/symlinks.go, andGEESEFS_VERSIONreading0.43.8instead of0.43.8-dc.2. The uploaded binary was correct, built fromdevata6b351c; only the tag was wrong, sogit checkout v0.43.8-dc.2gives a tree with none of the fork's changes. Pins the tag to the commit the workflow actually built.CLAUDE.md. The tag is then created deliberately at a known commit and the action attaches to it rather than choosing a target, so this class of bug cannot recur. It also publishes a full release directly, with no promote step.The bug was latent because earlier releases had their tag pushed beforehand, so the action attached to an existing ref.
v0.43.8-dc.2is the first release where it created the tag itself.The existing
v0.43.8-dc.2tag still needs moving toa6b351cseparately; this only prevents a recurrence.