ido7.1_irix4 added - #2068
Conversation
|
Any script to run the compiler should be packaged along with the compiler, not part of this repo |
|
Which compiler? The ido 7.1 one? Or a new one? |
|
Any compiler. But that |
|
Yeah makes sense... will move to compilers. Thanks! |
|
@mkst OK I created decompme/compilers#79 to have the script live there. Let me know if anything else needs changing! |
| platform=N64, | ||
| base_compiler=IDO71, | ||
| cc='"${COMPILER_DIR}/cc-irix4"' | ||
| ' --frontend "${COMPILER_DIR}/../ido4.1" --backend "${COMPILER_DIR}"' |
There was a problem hiding this comment.
Have you tested this? I was (am?) expecting the ido 7.1 bundle to include irix4 along with qemu-irix and whatever else is required, maybe ../ works but it would need testing to confirm..
|
Sorry for my terseness, I'm not home and replying on mobile which isn't a particularly enjoyable experience 😅 |
|
No rush to test! I had to run and I'm not sure if i messed something up in my haste so I'll look deeper when i get another chance |
| Checkbox("pass", "-v"), | ||
| ] | ||
|
|
||
| # The IRIX 4 frontend pipeline runs the compiler passes directly instead of |
There was a problem hiding this comment.
Please remove these comments, if you want to keep them somewhere they should be in your irix 4 cc script, they arent relevant to decopm.me
| # is a flagset rather than a parameter flag because parameter flags serialise | ||
| # as "-G=0", which IDO's argument parser does not accept. | ||
| COMMON_IDO_IRIX4_FLAGS: Flags = [ | ||
| FlagSet(id="ido_opt_level", flags=["-O0", "-O1", "-O2", "-O3"]), |
There was a problem hiding this comment.
do all these flags need to be recreated? can we not reuse some of the existing ones?
There was a problem hiding this comment.
i just went ahead and removed all the flag additions and made it an IDOCompiler. I'm not sure how to target flags/checkboxes without creating new classes so it's fine to just not do it and let the savvy user put in the flags manually. the most useful one to me was -Wp,-+ but this is probably niche enough that we can just share that knowledge among those who need it, and it'll be on all my scratches anyway. hopefully this meets your standards now! thanks for helping me through it
This is an attempt to get a more generic solution added than what was attempted in #2060. Since all the binaries are there, it uses a script to create the compiler. Hopefully this is acceptable, but if not please suggest alternatives!