fix(google-analytics): remove unnecessary runtime.fetch guard#452
Open
yuriassuncx wants to merge 1 commit into
Open
fix(google-analytics): remove unnecessary runtime.fetch guard#452yuriassuncx wants to merge 1 commit into
yuriassuncx wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if (runtime.fetch)guard inserver/main.ts, aligning with the standard pattern used by all other MCPs (e.g.google-sheets,google-calendar, etc.)runtime.fetchwould silently prevent the server from starting — the new pattern makes this failure visibleTest plan
bun run devingoogle-analytics/)client_id(verified locally)🤖 Generated with Claude Code
Summary by cubic
Removed the unnecessary
if (runtime.fetch)guard ingoogle-analytics/server/main.tsand now always callserve(runtime.fetch). This matches other MCPs and makes startup failures visible instead of silently not starting.Written for commit 429fd16. Summary will update on new commits.