Skip to content

fix(google-analytics): remove unnecessary runtime.fetch guard#452

Open
yuriassuncx wants to merge 1 commit into
mainfrom
fix/google-analytics-server-startup
Open

fix(google-analytics): remove unnecessary runtime.fetch guard#452
yuriassuncx wants to merge 1 commit into
mainfrom
fix/google-analytics-server-startup

Conversation

@yuriassuncx

@yuriassuncx yuriassuncx commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Removes the unnecessary if (runtime.fetch) guard in server/main.ts, aligning with the standard pattern used by all other MCPs (e.g. google-sheets, google-calendar, etc.)
  • With the guard, a falsy runtime.fetch would silently prevent the server from starting — the new pattern makes this failure visible

Test plan

  • Server starts correctly locally (bun run dev in google-analytics/)
  • OAuth authorize endpoint redirects to Google with correct client_id (verified locally)
  • No functional change in prod — server was already running, this is a cleanup

🤖 Generated with Claude Code


Summary by cubic

Removed the unnecessary if (runtime.fetch) guard in google-analytics/server/main.ts and now always call serve(runtime.fetch). This matches other MCPs and makes startup failures visible instead of silently not starting.

Written for commit 429fd16. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@yuriassuncx yuriassuncx enabled auto-merge June 15, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant