-
Notifications
You must be signed in to change notification settings - Fork 20
feat: added PBExplorerItemPurchaseResult and iap open event #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidejensen
wants to merge
8
commits into
main
Choose a base branch
from
feat/openexplorerui-iap-extension
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+47
−10
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
40219cd
feat: added PBExplorerPurchaseEventResult and iap open event
davidejensen c65b4c1
Refactor and improvements
davidejensen 7a07f26
Code suggestions
davidejensen 1a78584
feat: correlate OpenExplorerUi requests with their result events
popuz ca6849b
fix: make OpenExplorerUiRequest.request_id optional
popuz bffcf53
fix: allow concurrent panels and correct the EU_ITEM_PURCHASE comment
popuz 9012a1f
corrected comment
popuz b89cf79
docs: say why UiOpened exists next to the OpenExplorerUi verdict
popuz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
proto/decentraland/sdk/components/explorer_item_purchase_result.proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| syntax = "proto3"; | ||
| package decentraland.sdk.components; | ||
|
|
||
| import "decentraland/sdk/components/common/id.proto"; | ||
|
|
||
| option (common.ecs_component_id) = 1221; | ||
|
|
||
| // Grow-only value set appended to the scene root entity. | ||
| // Reports the outcome of an EU_ITEM_PURCHASE flow triggered via OpenExplorerUi. | ||
| message PBExplorerItemPurchaseResult { | ||
|
davidejensen marked this conversation as resolved.
|
||
| message Purchased {} | ||
| message Dismissed {} | ||
| message Failed {} | ||
|
|
||
| string urn = 1; | ||
| uint32 timestamp = 2; // The scene tick when the event occurred | ||
| uint32 request_id = 3; // The OpenExplorerUiRequest.request_id that caused this event; 0 if unset | ||
|
|
||
| oneof status { | ||
| Purchased purchased = 10; | ||
| Dismissed dismissed = 11; | ||
| Failed failed = 12; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.