fix(steam): select the declared milk-temperature sensor - #847
Conversation
tadelv
left a comment
There was a problem hiding this comment.
Two repository hard gates need to be addressed before this is ready:
-
The Contributor Responsibility checkbox is still unchecked.
AGENTS.mdexplicitly makes the completed PR template a pre-PR hard gate, and this checkbox is the template's responsibility/provenance attestation. Please check it once you've reviewed the submitted changes. -
The Verification section only states pass counts/results.
AGENTS.mdrequires evidence before assertions (show test output, not just that tests passed). Please add the relevant command output or otherwise provide concrete verification evidence; a successful CI run can serve that purpose once the fork workflow is allowed to run.
I did not find a merge-blocking issue in the sensor-selection implementation itself: selecting by the declared numeric temperature channel, preferring the exact Bengle Milk Probe contract, and reselecting on registry changes are consistent with #831.
cd3a997 to
d6937a4
Compare
|
Rechecked after the force-push/rebase. I don't see a remaining code-level blocker in the current diff, and the Contributor Responsibility checkbox is now fixed. The current CI failure is stale rather than a code failure: the workflow run was created before the checkbox was updated, and re-running the failed contribution-policy job replays that original PR event payload, so it still sees the checkbox as unchecked and skips the actual analyze/test/build jobs. Please trigger a fresh |
Summary
Fix SteamSequencer sensor selection so a declared temperature-capable source is selected by its channel contract and remains identity-fenced through lifecycle changes.
Linked Issue
Fixes #831
Verification
test/controllers/steam_sequencer_test.dart: 17 passed.test/integration/steam_sequencer_integration_test.dart: 1 passed.flutter analyze: no issues.Impact
Steam milk-temperature snapshots no longer depend on registry order or an unsuitable sensor's payload shape. This is an isolated sensor-selection bug fix and is a prerequisite for coexistence with the read-only E64 sensor plugin.
Contributor Responsibility
AI-assisted development is allowed. The submitter remains responsible for the submitted work.