Repository navigation
fix: exclude tests/test-data from sdist and GitHub source archives - #895
Open
samiraguiar wants to merge 1 commit into
Open
samiraguiar wants to merge 1 commit into
samiraguiar wants to merge 1 commit into
Conversation
The unencrypted (and even the zip-encrypted) malware-sample test corpus was still shipped inside the PyPI sdist via MANIFEST.in's `graft tests/test-data`, so any `pip install`/`pip download` that falls back to building from source downloads it. CI always runs against a full git checkout, never an installed package, so the corpus never needed to be part of the sdist/wheel. Also add tests/test-data to .gitattributes export-ignore so GitHub's auto-generated source archives (Download ZIP, release tarballs) omit it too, since sandboxes like Joe Sandbox have flagged oletools-master.zip as malicious because of these fixtures. Fixes decalage2#215.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unencrypted (and even the zip-encrypted) malware-sample test corpus was still shipped inside the PyPI sdist via MANIFEST.in's
graft tests/test-data, so anypip install/pip downloadthat falls back to building from source downloads it.CI always runs against a full git checkout, never an installed package, so the corpus never needed to be part of the sdist/wheel.
Also add tests/test-data to .gitattributes export-ignore so GitHub's auto-generated source archives (Download ZIP, release tarballs) omit it too, since sandboxes like Joe Sandbox have flagged oletools-master.zip as malicious because of these fixtures.
Fixes #215.