Skip to content

fix: exclude tests/test-data from sdist and GitHub source archives - #895

Open
samiraguiar wants to merge 1 commit into
decalage2:masterfrom
samiraguiar:fix/exclude-testdata-from-dist
Open

samiraguiar wants to merge 1 commit into
decalage2:masterfrom
samiraguiar:fix/exclude-testdata-from-dist

Conversation

@samiraguiar

Copy link
Copy Markdown
Contributor

The unencrypted (and even the zip-encrypted) malware-sample test corpus was still shipped inside the PyPI sdist via MANIFEST.in's graft tests/test-data, so any pip install/pip download that falls back to building from source downloads it.

CI always runs against a full git checkout, never an installed package, so the corpus never needed to be part of the sdist/wheel.

Also add tests/test-data to .gitattributes export-ignore so GitHub's auto-generated source archives (Download ZIP, release tarballs) omit it too, since sandboxes like Joe Sandbox have flagged oletools-master.zip as malicious because of these fixtures.

Fixes #215.

The unencrypted (and even the zip-encrypted) malware-sample test corpus
was still shipped inside the PyPI sdist via MANIFEST.in's `graft
tests/test-data`, so any `pip install`/`pip download` that falls back
to building from source downloads it.

CI always runs against a full git checkout, never an installed
package, so the corpus never needed to be part of the sdist/wheel.

Also add tests/test-data to .gitattributes export-ignore so GitHub's
auto-generated source archives (Download ZIP, release tarballs) omit
it too, since sandboxes like Joe Sandbox have flagged oletools-master.zip
as malicious because of these fixtures.

Fixes decalage2#215.
@decalage2
decalage2 self-requested a review September 29, 2026 20:45
@decalage2 decalage2 self-assigned this Sep 29, 2026
@decalage2 decalage2 added this to the oletools 0.60 milestone Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to deal with test data that might trigger antivirus engines

2 participants