Skip to content

tests/test_utils/utils.py: Adjust source code dir - #889

Open
leon-anavi wants to merge 1 commit into
decalage2:masterfrom
leon-anavi:leon/source-dir
Open

leon-anavi wants to merge 1 commit into
decalage2:masterfrom
leon-anavi:leon/source-dir

Conversation

@leon-anavi

Copy link
Copy Markdown

Fall back to the installed oletools location for the directory with source code if the sibling "oletools" dir doesn't exist (e.g. packaged/ptest installs).

Fall back to the installed oletools location for the directory with
source code if the sibling "oletools" dir doesn't exist (e.g.
packaged/ptest installs).

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
@decalage2
decalage2 self-requested a review July 15, 2026 19:54
@decalage2 decalage2 self-assigned this Jul 15, 2026
@decalage2 decalage2 added this to the Next Release milestone Jul 15, 2026
@decalage2

Copy link
Copy Markdown
Owner

Hi, thanks for this improvement. Could you please tell me how this can be tested?

@leon-anavi

Copy link
Copy Markdown
Author

Hi @decalage2,

Hi, thanks for this improvement. Could you please tell me how this can be tested?

I created this patch and #888 while working on the upgrade of recipe python3-oletools from the Yocto/OpenEmbedded layer meta-openembedded/meta-python. They were merged in meta-openembedded:
https://git.openembedded.org/meta-openembedded/commit/?h=master-next&id=3d2279ddbadbe16c4ef85abfe0c0194b2a4dddc3

For testing purposes I built core-image-minimal that includes python3-oletools and enabled Ptest (package test) for the distribution. After boot this image on Raspberry Pi 5 I ran the tests with:

ptest-runner python3-oletools

Although my setup is very specific, this particular oletools patch solves path issues for ptest-runner without breaking the way it works on other environments.

To explain better the context: the Yocto Project and OpenEmbedded aim to keep external patches to a minimum so I have opened these GitHub pull requests to merge my changes directly into the upstream oletools repository.

Thanks, Leon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants