Repository navigation
Add "Modules" as keyword for self-modification - #823
Open
DecimalTurn wants to merge 2 commits into
Open
DecimalTurn wants to merge 2 commits into
DecimalTurn wants to merge 2 commits into
Conversation
Contributor
Author
|
For the record, the snippet of code above won't be flagged by olevba as malicious, but does manage to import a VBA module even if "trust access to the vba project object model" is disabled! |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the addition of Modules to VBA self-modification detection.
No open issues 🎉
What changed in this PR
Extends olevba’s suspicious-keyword detection to recognize Modules as a possible VBA self-modification mechanism.
Changes:
- Adds
Modulesto the existing self-modification keyword group, covering the alternative module-import approach described in the PR.
| File | Description |
|---|---|
oletools/olevba.py |
Adds Modules to the VBA self-modification detection keywords. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently found this question on Stack Overflow, it shows how to import a new code module in VBA using the
Modulesobject.Here's a simplified snippet that illustrates how it works:
I always thought you had to use
VBComponents.Import, but turns out there is this undocumented method as well.