fix(ci): make Test Summary fail when any needed job did not succeed - #427
Merged
Conversation
The test-summary job ran with `if: always()` and unconditionally echoed success, so it showed green even when build-and-test or container-tests failed (seen on the PR #392/#393 container-build failures). It also only depended on 2 of the 4 real jobs in the workflow. Now it needs all four jobs (build-and-test, windows-python-integration, lint, container-tests), echoes each result, and exits non-zero unless every one is `success` — which also correctly fails on cancelled or skipped, since no job in this workflow is conditionally skipped by design. `if: always()` is kept so the job still runs and names the failure. Fixes #419 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #419
What
The
test-summaryjob ran withif: always()and unconditionally echoed "✅ CI pipeline completed", so the job showed green even whenbuild-and-testorcontainer-testsfailed — observed in practice on the PR #392/#393 container-build failures. It also only depended on 2 of the 4 real jobs in the workflow.Change
needsexpanded to all four jobs:build-and-test,windows-python-integration,lint,container-tests(previously omittedlintandwindows-python-integration— a summary that ignores half the workflow isn't a summary).needs.*.resultand exits non-zero unless every result issuccess. This also fails oncancelled/skipped, which is correct here: no job in this workflow is conditionally skipped by design, so a non-success result always means the pipeline did not fully pass.if: always()is kept so the job still runs on failure and names which job failed.Note for branch protection
With this change Test Summary becomes a meaningful single required-check candidate: it now transitively covers every job in ci.yml. SUPPLY-CHAIN-SECURITY.md already lists it among the required checks, while actual branch protection currently requires only ubuntu Build and Test + Lint Code — worth aligning whenever convenient.
🤖 Generated with Claude Code