debezium/dbz#2128 feat: add PGVector adapter and core logging improve…#11
debezium/dbz#2128 feat: add PGVector adapter and core logging improve…#11KMohnishM wants to merge 1 commit into
Conversation
ad2c0a7 to
e18e631
Compare
279505c to
1384ebd
Compare
e18e631 to
88a4341
Compare
1384ebd to
089627a
Compare
88a4341 to
55f909e
Compare
089627a to
f364c36
Compare
55f909e to
b1b2be7
Compare
vjuranek
left a comment
There was a problem hiding this comment.
Juts one minor comment about logging, otherwise LGTM.
| """ | ||
| try: | ||
| self._store.delete(ids=[doc_id]) | ||
| logger.debug("PGVector delete: %s", doc_id) |
There was a problem hiding this comment.
IMHO it's better do the logging first and then do the action itself - if anything goes wrong, you know from log what action triggered it (e.g. exception with full stack trace can swallowed somewhere etc)
b1b2be7 to
d6894d4
Compare
…ments Signed-off-by: KMohnishM <kmohnishm@gmail.com>
d6894d4 to
a9e236e
Compare
|
@KMohnishM I am a bit confused, the PR contains Miluvs related changes I already merged in the other PR. |
7a4a81c to
a9e236e
Compare
|
Hi @jpechane, apologies for the confusion! Here is what happened with the stacked branches:
Everything should look clean and correct now! |
|
@jpechane One small request is to merge every PR also to main branch as the PRs are stacked there base branch is the sub sequent branch rather than main branch. |
|
@KMohnishM Thanks for the explanation, I completely forgot about the PR stacking |
Description
This Pull Request implements the first half of GSoC Week 5 targets under tracking issue debezium/dbz#2128. It introduces support for the PGVector (PostgreSQL) vector database backend and establishes a standardized, library-wide logging and observability framework.
Key Changes
PGVectorAdapterinpydebeziumai/adapters/pgvector.pyextending the coreVectorStoreAdaptercontract.langchain-postgresbackend underneath to perform idempotentupsert,delete, and retriever generation.PGVectorAdapterin the public adapters interface (pydebeziumai/adapters/__init__.py).SyncManager: Log all CDC synchronization activities (INFOlevel for inserts, updates, deletes, and soft-deletes) and clear warnings for retries and Dead Letter Queue (DLQ) routing.DocumentBuilder: Added debug logs tracing document parsing, building, and tombstone discard phases.IdStrategy&ProjectionPolicy: Injected debug logs indicating selected formatting policies and resolved document ID values.tests/unit/test_pgvector_adapter.pyvalidating initialization, correct backend instantiation, mock-upsert, mock-delete, exception fallbacks, and retriever exports.Verification Results
All code validation checks have been successfully run and passed within WSL:
All checks passed!).Success: no issues found in 22 source fileswith strict mode enabled).