Enforce lowercase usernames, per-field validation, and InfoTip requirements by ka-wah · Pull Request #229 · deathbyknowledge/gsv

ka-wah · 2026-07-29T13:05:10Z

Summary

Improves the onboarding and login username experience with lowercase enforcement, real-time per-field validation, and cleaner requirements display.

Changes

Lowercase enforcement

Onboarding username, agent name, and login username fields now auto-lowercase on every keystroke — typing Hank shows hank instantly

Per-field validation errors

Each username field independently shows its own error status/message in real-time (red border + error text below the field)
Both fields can show errors simultaneously, making it clear which one(s) fail
validateSetupDetails now checks the raw (untrimmed) value against isValidUsername, so leading/trailing spaces are properly rejected instead of silently passing after trim

Requirements as InfoTip

Username format requirements moved from static description text below the field to a hoverable circle-with-? InfoTip next to the field label (shown on hover/focus)

Review stage formatting

Account summary on step 3 reformatted to kawah - friend4 (agent) instead of kawah · agent friend4

Login username clear fix

Removed an effect that reset the login username field back to the snapshot value when the user cleared it, allowing proper backspace-to-empty

Files changed

web/src/app/features/session/setup/AccountDetails.tsx
web/src/app/features/session/LoginScreen.tsx
web/src/app/features/session/sessionDomain.ts
web/src/app/features/session/setup/ReviewStage.tsx
web/src/app/features/session/useSessionScreensState.ts

…ip for requirements - Onboarding + login username fields auto-lowercase input on every keystroke - Per-field real-time validation: each username field shows its own error status/message independently, so it's clear which field(s) fail - Username format requirements moved from description text to InfoTip (circle-with-? icon) next to the field label, shown on hover/focus - validateSetupDetails now checks raw (untrimmed) value against isValidUsername so leading/trailing spaces are properly rejected - Review stage account summary reformatted: 'kawah - friend4 (agent)' instead of 'kawah · agent friend4'

Remove the effect that reset loginUsername back to snapshot.username whenever the field was cleared, allowing proper backspace-to-empty.

ka-wah · 2026-07-29T13:13:25Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 86ab5b54f5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-29T13:18:09Z

        return { message: "Username is required.", step };
      }
-      if (!isValidUsername(username)) {
+      if (!isValidUsername(rawUsername)) {


Enforce username rules at the setup syscall

This check rejects padded names only in the web wizard. buildSetupPayload/SessionService.setup still trim before sending, and gateway/src/kernel/sys/setup.ts trims in readRequiredString/readOptionalString before applying USERNAME_RE, so direct sys.setup/SDK callers can still submit " alice " or " friday " and get silently-created alice/friday while the UI rejects the same input. Because username format is setup syscall semantics, enforce or normalize it at that boundary instead of only this caller.

AGENTS.md reference: AGENTS.md:L22-L26

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-29T13:18:09Z

-      setLoginUsername(snapshot.username);
-    }
-  }, [loginUsername, snapshot.username]);
+


Keep the login username in sync after setup

After a first-boot setup, this hook has been mounted since the pre-setup snapshot, so loginUsername was initialized as empty and this deletion removes the only path that copied the newly-created snapshot.username into the login form. If the session later locks without a full reload, the login screen no longer pre-fills the account that was just created; consider tracking whether the user has edited/cleared the field before suppressing snapshot updates.

Useful? React with 👍 / 👎.

…ill after setup - Validate raw (untrimmed) username/agentName against USERNAME_RE in parseSetupIdentity/parseSetupAgentName so padded names are rejected at the setup syscall, not only in the web wizard - Add loginUsernameTouched flag so login field syncs from snapshot.username after first-boot setup, but stops syncing once user manually edits

ka-wah · 2026-07-29T13:40:11Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0146d49907

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-29T13:44:50Z

+    if (!loginUsernameTouched && snapshot.username) {
+      setLoginUsername(snapshot.username);
+    }


Mark login username edits as touched

When snapshot.username changes after the user has typed or cleared the login field, this effect still overwrites the field because loginUsernameTouched is initialized to false and is never set to true in the returned onUsername handler. The new guard therefore does not actually mean “the user hasn't manually edited,” so session updates during setup/lock/reconnect can replace in-progress login input; set the touched flag when handling username edits before relying on it here.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-29T13:44:50Z

+  const usernameValue = draft.account.username;
+  const usernameInvalid = usernameValue.length > 0 && !isValidUsername(usernameValue);
+  const agentValue = draft.account.agentName;
+  const agentInvalid = agentValue.length > 0 && !isValidUsername(agentValue);


Keep optional agent validation consistent

If the optional personal-agent field contains only spaces, this marks the field invalid because agentValue.length > 0, but validateSetupDetails trims the same value, treats it as blank, and allows the user to advance while buildSetupPayload omits the agent name. That leaves a red error visible on a form that can still submit successfully; base the inline invalid state on the same trimmed value, or make submit validation block whitespace-only input too.

Useful? React with 👍 / 👎.

…ation with submit - Set loginUsernameTouched=true in onUsername handler so the snapshot sync effect stops overwriting user input after manual edits - Use trimmed agentValue for the inline invalid check so whitespace-only input doesn't show a red error while submit treats it as blank

ka-wah · 2026-07-29T14:17:40Z

@codex review

chatgpt-codex-connector · 2026-07-29T14:20:56Z

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: fc8c243990

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ka-wah added 2 commits July 29, 2026 14:49

fix: prevent username re-fill on clear in login screen

86ab5b5

Remove the effect that reset loginUsername back to snapshot.username whenever the field was cleared, allowing proper backspace-to-empty.

ka-wah requested a review from Copilot July 29, 2026 13:07

Copilot started reviewing on behalf of ka-wah July 29, 2026 13:08 View session

This comment was marked as low quality.

Sign in to view

chatgpt-codex-connector Bot reviewed Jul 29, 2026

View reviewed changes

fix: use middot instead of dash for agent name in onboarding review

7a8e82e

deathbyknowledge merged commit c3898b5 into main Jul 30, 2026
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enforce lowercase usernames, per-field validation, and InfoTip requirements - #229

Enforce lowercase usernames, per-field validation, and InfoTip requirements#229
deathbyknowledge merged 5 commits into
mainfrom
feat/onboarding-lowercase-validation

ka-wah commented Jul 29, 2026

Uh oh!

This comment was marked as low quality.

Uh oh!

ka-wah commented Jul 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jul 29, 2026

Uh oh!

chatgpt-codex-connector Bot Jul 29, 2026

Uh oh!

ka-wah commented Jul 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jul 29, 2026

Uh oh!

chatgpt-codex-connector Bot Jul 29, 2026

Uh oh!

ka-wah commented Jul 29, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ka-wah commented Jul 29, 2026

Summary

Changes

Lowercase enforcement

Per-field validation errors

Requirements as InfoTip

Review stage formatting

Login username clear fix

Files changed

Uh oh!

This comment was marked as low quality.

Uh oh!

ka-wah commented Jul 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

ka-wah commented Jul 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

ka-wah commented Jul 29, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants