generate task titles - #227
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11816d4717
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }); | ||
| if (!started) return; | ||
|
|
||
| this.ctx.waitUntil(this.generateTaskTitle(message, fallback)); |
There was a problem hiding this comment.
When an auto-title request is in flight and the user runs proc.reset or proc.conversation.reset, the reset path cancels run-scoped work but this waitUntil title job is not tied to a run, AbortSignal, lifecycle epoch, or conversation generation. After the model call returns, generateTaskTitle only checks that the default title still equals the fallback, which resets preserve, so a task can be retitled from a message that was just cleared; capture the generation/epoch before launching and ignore or cancel the result after reset.
AGENTS.md reference: AGENTS.md:L72-L75
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6dfbff1a2f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| let generated: string | null = null; | ||
| try { | ||
| const config = this.buildAiTextGenerateConfig(); | ||
| const result = await this.kernelRpc("ai.text.generate", { |
There was a problem hiding this comment.
When a new auto-titled task is reset or killed while this ai.text.generate call is in flight, the request is not tied to any AbortSignal or request controller; resetExecutionState only aborts run/tool/CodeMode controllers, so the provider call can continue until its 20s timeout after teardown. Please pass a lifecycle-owned signal that reset/kill cancels, or register this background syscall with the existing cancellation path.
AGENTS.md reference: AGENTS.md:L27-L28
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
No description provided.