making a custom ai endpoint option#352
Open
GRbit wants to merge 1 commit intoddworken:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there again!
Once again, thanks for the awesome project, it's a pleasure to use it. I especially enjoy the AI functionality, right what I need, no bullshit, just one liner in response - works like magic!
Though, it would be nice to have an option to use my own OpenAI compatible endpoints like llama.cpp or ollama. This is what this PR does. The goal was to make it as small as possible, yet working, so you can save time reviewing it.
P.S.: From what I see, it looks like AI related code is a bit messy, for example how GetAiProvider is used. Like, previously it was set to a constant, and then there is an
ifchecking what's return. Doesn't make much sense, since it's always the same. I end up with code like this myself many times switching ideas and concepts during development. Would you like to see a better refactoring maintaining backward compatibility? If yes, I might find time to do it.