chore(transport): pass the call timeout as an argument - #1
Closed
dcrousso wants to merge 1 commit into
Closed
Conversation
`InnerSendMessageToServerAsync` picked the call timeout out of the parameters by name, which silently claims any future protocol parameter that happens to be called `timeout`. thread it through `SendMessageToServerAsync` as its own argument instead, matching the `playwright` and `playwright-java` clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on microsoft#3338.
Passes the call timeout as a separate
SendMessageToServerAsyncargument instead of extracting atimeoutentry from the params dictionary.This matches the Java and JavaScript clients and avoids claiming any future protocol field named
timeout.Retarget this to
mainafter the roll merges.