Fix: Trigger @dcoapp recheck from PR reviews#290
Merged
Conversation
|
@tykeal is attempting to deploy a commit to the DCO App Team on Vercel. A member of the Team first needs to authorize it. |
GitHub gates issue_comment webhooks behind the Issues permission. The deployed app only has pull_requests:read, and adding Issues:read would force every existing installation admin to re-approve a new permission scope. As a result, the app never received the comment events added for @dcoapp recheck. Listen for pull_request_review.submitted and pull_request_review_comment.created instead. Both events are available under the existing pull_requests:read permission, so the fix does not require a permission bump. Remove the non-working issue_comment path and defer plain PR conversation comments to future work. The command now matches when @dcoapp recheck appears on its own line, case-insensitively with surrounding whitespace allowed. Update the README to describe review summaries and inline review comments as the supported surfaces. Add review-comment coverage for require.members: false so rechecks exercise org membership lookups with realistic webhook payloads. Re dcoapp#289 Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tykeal
force-pushed
the
fix/recheck-via-reviews
branch
from
d6cd616 to
8be4670
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ModeSevenIndustrialSolutions
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the #289 root cause without requiring a permission bump. The previous
issue_commentimplementation needed the Issues permission, which the app doesnot have. Adding that permission would force every installation admin to
re-approve the app, so production never received those webhook events.
This switches recheck handling to
pull_request_review.submittedandpull_request_review_comment.created. Both are covered by the existingpull_requests: readpermission, so this requires no app permission increase andno installation re-approval. The non-working
issue_commentpath is removed andplain PR conversation comments are deferred to a future expanded-scope change.
To invoke a recheck, put this command on its own line in either a PR review
summary or an inline review comment:
Re #289. This intentionally does not auto-close the issue: production still
requires a redeploy and enabling the two review events in the GitHub App settings
before the fix works there.
Validation
npm testpassed with 100% statement/branch/function/line coverage.pre-commit run --all-filespassed.Expected checks
preview-smokeis expected to fail on this PR because no authorized Vercelpreview exists for this SHA. That is the intended fail-on-no-preview behavior
from CI: Fix smoke tests for fork pull requests #287, not a regression.
Vercelorg-gate check is expected.