Close the migrated vocabulary schema - #710
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
description,articulatory_notes, and structuredexamplesdirectly in every lexicon entryconceptandgrammatical_notesproperties and their migration-era fallback branchesNo vocabulary entry, Phi word, gloss, example, or generated lexicon reference changes in this PR.
Behaviour
The schema now rejects an entry when
articulatory_notesorexamplesis absent, even ifsound_symbolismor old grammar prose is present. BecauseadditionalPropertiesremains false, either retired property is also rejected explicitly. The coverage report still classifies legacy, partial, dual, and target shapes, but the first three are evidence of a regression rather than accepted schema states.NTP-01 is marked done under D115, and NTP-02 becomes the next package in the status-tracked plan.
Prose review
The changed reader-facing reference prose received the required Humanizer and Phi voice pass. One dense validator-coverage sentence had become a long mechanical chain; it is now a short inventory whose items can be scanned independently.
Checks
python3 scripts/validate_examples.py(1,305 entries, 0 errors, 0 warnings)python3 scripts/validate_sentences.py(3,313 examples, 0 errors)python3 scripts/test_sentence_validator.py(25 tests)python3 scripts/test_vocabulary_schema.py(25 tests)python3 scripts/content_vocabulary_decisions.py --check(82 batches, 280 decisions)python3 scripts/test_content_vocabulary_decisions.py(8 tests)python3 scripts/test_name_forms.py(20 tests)python3 scripts/test_translation_layers.py(11 tests)python3 scripts/translation_process_status.py --check(20 translations)python3 scripts/test_translation_process_status.py(9 tests)python3 scripts/audit_phonetic_neighbors.py --output /tmp/phonetic_neighbors_ntp01.txtand baseline comparison (250 pairs, unchanged)python3 scripts/vocabulary_prose_coverage.py(1,305 target entries, committed report unchanged)python3 scripts/generate_reference.py(generated references unchanged)python3 scripts/build_site.pygit diff --check